Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Third Reality sensors #3336

Closed
wants to merge 8 commits into from
Closed

Conversation

3reality-support
Copy link

@3reality-support 3reality-support commented Aug 30, 2024

Proposed change

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (0a0f667) to head (089b76e).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3336      +/-   ##
==========================================
+ Coverage   89.79%   89.84%   +0.04%     
==========================================
  Files         323      325       +2     
  Lines       10414    10465      +51     
==========================================
+ Hits         9351     9402      +51     
  Misses       1063     1063              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the new quirk Adds support for a new device label Sep 16, 2024
@TheJulianJES TheJulianJES changed the title add 3r project py Add Third Reality sensors Sep 16, 2024
@3reality-support
Copy link
Author

Is there any problem with the code? It's been three weeks now, please let me know @TheJulianJES

@TheJulianJES TheJulianJES added the needs review This PR should be reviewed soon, as it generally looks good. label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review This PR should be reviewed soon, as it generally looks good. new quirk Adds support for a new device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants